Add isOpen() method #387
Closed
Add isOpen() method #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a few nits. You're missing a semicolon which is causing your tests to fail. You can also drop the As for the code content; Is an open FD analogous to an open port? I'm fairly certain that this wont work on window as we don't get a file descriptor for the port. I think we'd have to keep a flag on the instance that is hooked into the events. |
|
closed. |
arahlf
added a commit
to arahlf/node-serialport
that referenced
this pull request
Apr 27, 2015
The isOpen method was originally proposed to be added as part of serialport#387 but was never merged. That original PR had updated the README as part of it, but when the isOpen was actually added later ( serialport@21a076a ), the docs were never updated.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for your work on serialport. The isOpen method would be useful for my project - I wondered whether you thought it would be appropriate to add.
Regards, John.